[Requests] Comments on SWE Common Data Model v2.0

Simon Cox simon.cox at jrc.ec.europa.eu
Fri Mar 26 10:56:42 EDT 2010


PART A

1. Evaluator:
        Simon Cox, JRC
2. Submission: 
        OGC 08-094 - SWE Common Data Model v2.0
 
 
PART B

1. Comment: 1. 

2. Implementation Specification Section number: 
         Clause 4

3. Criticality: Major

4. Comments/justifications for changes: 
 
Several of the terms refer to definitions from other documents, but have
altered the text compared with the original. I can see that in some cases
additional clarification is intended, but it is inappropriate to merge this
with the quoted definition, which should be preserved intact. Additional
information should be clearly labelled as such, for example as a 
 
NOTE: Additional information. 
 
The following resources can be checked as well: 
http://www.isotc211.org/Terminology.htm
Also look at Clause 4 in O&M v2.0 (10-004r1), which have been reviewed in
detail by the terminology police, and provides examples of how to refer to
both ISO and other sources. 
 
 
1. Comment: 2.

2. Implementation Specification Section number: 
        Clause 8.1.1. 
        basic_types.xsd

3. Criticality: Major

4. Comments/justifications for changes: 
 
The schema uses a new abstract base type AbstractSWEType in place of similar
GML types. No explanation is provided for why this was necessary. The one
significant difference is the 'extension' element. However, this could be
appended to the GML content model with no change in functionality. 
 
 
1. Comment: 3. 

2. Implementation Specification Section number: 
         Clause 7.4
        Figure 7.29
        block_components.xsd

3. Criticality: Minor

4. Comments/justifications for changes: 
 
Matrix|DataArray::elementCount:Count
and XML elementCount is type='swe:CountPropertyType'. 
The role of these uses of Count is trivial compared to the qualified and
identified values that the Count class was created for. 
Suggest simplification to xs:nonNegativeInteger or similar?
 
 
1. Comment: 4. 

2. Implementation Specification Section number: 
         8.5.4., A.11.7, A.12.5

3. Criticality: Minor

4. Comments/justifications for changes: 
 
EBNF is defined by ISO 14977, and is used in this spec. 
However, ABNF is defined by IETF RFC 5234, and is the more commonly used
syntax, with open-source processing engines available. 
Consider switching to ABNF. 
 
--------------------------------------------------------
Simon Cox

European Commission, Joint Research Centre 
Institute for Environment and Sustainability 
Spatial Data Infrastructures Unit, TP 262 
Via E. Fermi, 2749, I-21027 Ispra (VA), Italy 
Tel: +39 0332 78 3652 
Fax: +39 0332 78 6325 
 <mailto:simon.cox at jrc.ec.europa.eu> mailto:simon.cox at jrc.ec.europa.eu 
 <http://ies.jrc.ec.europa.eu/simon-cox>
http://ies.jrc.ec.europa.eu/simon-cox 

SDI Unit:  <http://sdi.jrc.ec.europa.eu/> http://sdi.jrc.ec.europa.eu/ 
IES Institute:  <http://ies.jrc.ec.europa.eu/> http://ies.jrc.ec.europa.eu/ 
JRC:  <http://www.jrc.ec.europa.eu/> http://www.jrc.ec.europa.eu/

--------------------------------------------------------

 

Any opinions expressed are personal unless otherwise indicated. 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.opengeospatial.org/pipermail/requests/attachments/20100326/26c4045a/attachment.htm 


More information about the Requests mailing list