[CITE-Forum] WMS 1.3 trunk tests not considering queryable attribute is optional

Sebastian Goerke goerke at lat-lon.de
Tue Dec 3 07:26:15 EST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Andrea,

yes, you are right. Do you have a list of the failing test to better
locate the positions where to include your suggested patch?

Best Regards

Sebastian

Am 01.12.2013 15:49, schrieb Andrea Aime:
> Hi, running the WMS 1.3 tests from trunk I've noticed that a couple
> of tests fail to take into account the Layer queryable attribute is
> optional, and defaults to 0. Fixing the tests is just a matter of
> adding a "and @queryable" in the tests, as in the following patch:
> 
> diff --git a/wms/1.3.0/trunk/ctl/getfeatureinfo.xml 
> b/wms/1.3.0/trunk/ctl/getfeatureinfo.xml index 3e0b65e..67bc5ec
> 100644 --- a/wms/1.3.0/trunk/ctl/getfeatureinfo.xml +++
> b/wms/1.3.0/trunk/ctl/getfeatureinfo.xml @@ -32,7 +32,7 @@ 
> <xsl:otherwise> <ctl:call-test name="getfeatureinfo:exceptions"/> 
> <xsl:choose> -                  <xsl:when 
> test="not(wms:Capability//wms:Layer[functions:boolean-as-integer(@queryable)
>
> 
= 1]/wms:Name)">
> +                  <xsl:when 
> test="not(wms:Capability//wms:Layer[@queryable and 
> functions:boolean-as-integer(@queryable) = 1]/wms:Name)">^M 
> <ctl:message>No queryable layers in capabilities 
> XML.</ctl:message> <xsl:if test="$queryable='queryable'"> 
> <ctl:fail/> @@ -107,7 +107,7 @@ <ctl:call-test
> name="getfeatureinfo:invalid-query_layers"/> <ctl:call-test
> name="getfeatureinfo:query_layers-not-queryable"/> <xsl:variable
> name="capabilities" select="."/> -         <ctl:for-each
> select="wms:Capability//wms:Layer[wms:Name and 
> functions:boolean-as-integer(@queryable) = 1]/wms:Name"> +
> <ctl:for-each select="wms:Capability//wms:Layer[wms:Name and 
> @queryable and functions:boolean-as-integer(@queryable) =
> 1]/wms:Name">^M <ctl:call-test
> name="getfeatureinfo:each-queryable-layer"> <ctl:with-param
> name="capabilities" select="$capabilities"/> <ctl:with-param
> name="layer" select="string(.)" label="each queryable layer"
> label-expr="concat('layer "', ., '"')"/>
> 
> 
> Cheers Andrea
> 
> -- == Our support, Your Success! Visit
> http://opensdi.geo-solutions.it for more information. ==
> 
> Ing. Andrea Aime @geowolf Technical Lead
> 
> GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054  Massarosa
> (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39
> 339 8844549
> 
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> 
> -------------------------------------------------------
> 
> 
> _______________________________________________ CITE-Forum mailing
> list CITE-Forum at lists.opengeospatial.org 
> https://lists.opengeospatial.org/mailman/listinfo/cite-forum
> 

- -- 
l a t / l o n  GmbH
Aennchenstrasse 19               53177 Bonn, Germany
phone ++49 +228 18496-0          fax ++49 +228 18496-29
http://www.lat-lon.de            http://www.deegree.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlKdzecACgkQq1hDh4aJykIBvgCgu4fJ/lESJy35yqLyGMQiWQiv
dNIAn20OLrfn1T8OsCh4CFDy3CLzYaj5
=9rnu
-----END PGP SIGNATURE-----


More information about the CITE-Forum mailing list