[CITE-Forum] WMS 1.3 trunk tests not considering queryable attribute is optional

Andrea Aime andrea.aime at geo-solutions.it
Sun Dec 1 09:49:41 EST 2013


Hi,
running the WMS 1.3 tests from trunk I've noticed that a couple of tests
fail to take
into account the Layer queryable attribute is optional, and defaults to 0.
Fixing the tests is just a matter of adding a "and @queryable" in the
tests, as in
the following patch:

diff --git a/wms/1.3.0/trunk/ctl/getfeatureinfo.xml
b/wms/1.3.0/trunk/ctl/getfeatureinfo.xml
index 3e0b65e..67bc5ec 100644
--- a/wms/1.3.0/trunk/ctl/getfeatureinfo.xml
+++ b/wms/1.3.0/trunk/ctl/getfeatureinfo.xml
@@ -32,7 +32,7 @@
             <xsl:otherwise>
                <ctl:call-test name="getfeatureinfo:exceptions"/>
                <xsl:choose>
-                  <xsl:when
test="not(wms:Capability//wms:Layer[functions:boolean-as-integer(@queryable)
= 1]/wms:Name)">
+                  <xsl:when test="not(wms:Capability//wms:Layer[@queryable
and functions:boolean-as-integer(@queryable) = 1]/wms:Name)">^M
                      <ctl:message>No queryable layers in capabilities
XML.</ctl:message>
                      <xsl:if test="$queryable='queryable'">
                         <ctl:fail/>
@@ -107,7 +107,7 @@
          <ctl:call-test name="getfeatureinfo:invalid-query_layers"/>
          <ctl:call-test name="getfeatureinfo:query_layers-not-queryable"/>
          <xsl:variable name="capabilities" select="."/>
-         <ctl:for-each select="wms:Capability//wms:Layer[wms:Name and
functions:boolean-as-integer(@queryable) = 1]/wms:Name">
+         <ctl:for-each select="wms:Capability//wms:Layer[wms:Name and
@queryable and functions:boolean-as-integer(@queryable) = 1]/wms:Name">^M
             <ctl:call-test name="getfeatureinfo:each-queryable-layer">
                <ctl:with-param name="capabilities" select="$capabilities"/>
                <ctl:with-param name="layer" select="string(.)" label="each
queryable layer" label-expr="concat('layer "', ., '"')"/>


Cheers
Andrea

-- 
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opengeospatial.org/pipermail/cite-forum/attachments/20131201/3d866e76/attachment.html>


More information about the CITE-Forum mailing list